-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1122 refactor secp256k1 #1258
Merged
Merged
1122 refactor secp256k1 #1258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
lucanicoladebiasi
force-pushed
the
1122-refactor-secp256k1
branch
from
September 9, 2024 14:44
6198984
to
373074b
Compare
leszek-vechain
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The class
packages/core/src/secp256k1/Secp256k1.ts
unifies any reference to SECP256K1 functionalities, constants and methods. Albeit the class is made of static methods, this approach simplifies name space conflicts with 3rd parties libraries exportingsecp256k1
constants and it is coherent with the OOP paradigm adopted in the SDK.The examples and documentation are reviewed, the
docs/diagrams/architecture/secp256k1.md
file documents the class.Code documentation reports precisely the noble/scure use of cryptographic sensitive algorithms and the fall-back to global.crypto for the runtime throwing exceptions.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
yarn test:examples
yarn test:solo
yarn test:unit
Test Configuration:
Checklist: